fix: trace tool forwarding decisions
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -860,6 +860,33 @@ class ToolCallBridgeTests(unittest.IsolatedAsyncioTestCase):
|
||||
self.assertIsInstance(cfg["tool_choice"], dict)
|
||||
self.assertEqual(spy_client.last_complete_args[2], "agent")
|
||||
|
||||
async def test_openai_stream_forwards_tool_config_when_enabled(self) -> None:
|
||||
spy_client = _SpyClient(stream_events=[{"type": "text", "text": "ok"}], complete_result={})
|
||||
req = ChatCompletionsRequest(
|
||||
model="org_auto",
|
||||
messages=[{"role": "user", "content": "hi"}],
|
||||
stream=True,
|
||||
tools=[{"type": "function", "function": {"name": "lookup", "parameters": {}}}],
|
||||
tool_choice={"type": "function", "function": {"name": "lookup"}},
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(main, "pool", _FakePool(_FakeInstance(spy_client))),
|
||||
patch.object(main, "chat_guard", _FakeGuard()),
|
||||
patch.object(main, "_ensure_instance_logged_in", AsyncMock(return_value={"id": "u"})),
|
||||
patch.object(main.stats_collector, "record_chat", AsyncMock(return_value=None)),
|
||||
_SettingsPatch(tool_forward_enabled=True),
|
||||
):
|
||||
response = await main.v1_chat_completions(req, _make_request("/v1/chat/completions"))
|
||||
await _collect_stream(response)
|
||||
|
||||
self.assertIn("tool_config", spy_client.last_stream_kwargs)
|
||||
cfg = spy_client.last_stream_kwargs["tool_config"]
|
||||
self.assertEqual(cfg["provider"], "openai")
|
||||
self.assertEqual(len(cfg["tools"]), 1)
|
||||
self.assertIsInstance(cfg["tool_choice"], dict)
|
||||
self.assertEqual(spy_client.last_stream_args[2], "agent")
|
||||
|
||||
async def test_openai_non_stream_does_not_forward_tool_config_when_disabled(self) -> None:
|
||||
spy_client = _SpyClient(stream_events=[], complete_result={"text": "ok", "toolEvents": []})
|
||||
req = ChatCompletionsRequest(
|
||||
@@ -1054,6 +1081,40 @@ class ToolCallBridgeTests(unittest.IsolatedAsyncioTestCase):
|
||||
self.assertEqual(openai_spy.last_complete_args[2], "chat")
|
||||
self.assertEqual(anthropic_spy.last_complete_args[2], "chat")
|
||||
|
||||
async def test_anthropic_stream_forwards_tool_config_when_enabled(self) -> None:
|
||||
spy_client = _SpyClient(stream_events=[{"type": "text", "text": "ok"}], complete_result={})
|
||||
req = AnthropicMessagesRequest(
|
||||
model="claude-3-5-sonnet-20241022",
|
||||
max_tokens=128,
|
||||
messages=[{"role": "user", "content": "hi"}],
|
||||
stream=True,
|
||||
tools=[{"name": "lookup", "input_schema": {"type": "object", "properties": {}}}],
|
||||
tool_choice={"type": "tool", "name": "lookup"},
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(main, "pool", _FakePool(_FakeInstance(spy_client))),
|
||||
patch.object(main, "chat_guard", _FakeGuard()),
|
||||
patch.object(main, "_ensure_instance_logged_in", AsyncMock(return_value={"id": "u"})),
|
||||
patch.object(main.stats_collector, "record_chat", AsyncMock(return_value=None)),
|
||||
patch.object(main.settings, "api_keys", ["test-key"]),
|
||||
_SettingsPatch(tool_forward_enabled=True, default_ask_mode="chat"),
|
||||
):
|
||||
response = await main.v1_messages(
|
||||
req,
|
||||
_make_request(
|
||||
"/v1/messages",
|
||||
headers={"x-api-key": "test-key", "anthropic-version": "2023-06-01"},
|
||||
),
|
||||
)
|
||||
await _collect_stream(response)
|
||||
|
||||
self.assertIn("tool_config", spy_client.last_stream_kwargs)
|
||||
cfg = spy_client.last_stream_kwargs["tool_config"]
|
||||
self.assertEqual(cfg["provider"], "anthropic")
|
||||
self.assertEqual(len(cfg["tools"]), 1)
|
||||
self.assertEqual(spy_client.last_stream_args[2], "agent")
|
||||
|
||||
async def test_anthropic_non_stream_does_not_forward_tool_config_when_disabled(self) -> None:
|
||||
spy_client = _SpyClient(stream_events=[], complete_result={"text": "ok", "toolEvents": []})
|
||||
req = AnthropicMessagesRequest(
|
||||
|
||||
Reference in New Issue
Block a user